Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding repos files & providing supplemental ones in PRs #524

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Support overriding repos files & providing supplemental ones in PRs #524

merged 1 commit into from
Feb 13, 2021

Conversation

christophebedard
Copy link
Member

Relates to #157

Relates to #490

Similar to ci.ros2.org, this allows declaring PR dependencies by providing:

  • repos file(s) to override the one(s) defined through the vcs-repo-file-url action input
  • supplemental repos file(s) to be used along with the rest

This is done in a PR description, e.g.:

action-ros-ci-repos-override : https://gist.github.com/some-user/some.repos
action-ros-ci-repos-override : https://gist.github.com/some-user/some-other.repos
action-ros-ci-repos-supplemental : https://gist.github.com/some-user/some-supplemental.repos
action-ros-ci-repos-supplemental : file://path/to/some/other/supplemental.repos

but without the space before the colon (otherwise e2e tests for this PR will try to use those fake links).

To provide some feedback, lists of links of detected overrides/supplemental files are printed in the action output, e.g.:

Screenshot from 2021-02-06 17-58-43

The feature is currently only tested using unit tests since end-to-end tests are a bit harder for this, but I have tested it and it works great.

@christophebedard christophebedard requested a review from a team as a code owner February 6, 2021 23:01
@christophebedard christophebedard requested review from thomas-moulard and lucashan and removed request for a team February 6, 2021 23:01
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #524 (77de8d1) into master (4c63c81) will increase coverage by 6.66%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   35.76%   42.42%   +6.66%     
==========================================
  Files           1        2       +1     
  Lines         151      198      +47     
  Branches       29       36       +7     
==========================================
+ Hits           54       84      +30     
- Misses         97      114      +17     
Impacted Files Coverage Δ
src/action-ros-ci.ts 32.54% <5.26%> (-3.22%) ⬇️
src/dependencies.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c63c81...136b719. Read the comment docs.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but I'd prefer to remove the unrelated formatting

src/action-ros-ci.ts Outdated Show resolved Hide resolved
src/action-ros-ci.ts Outdated Show resolved Hide resolved
@emersonknapp emersonknapp enabled auto-merge (squash) February 12, 2021 20:40
@emersonknapp emersonknapp merged commit 32507b5 into ros-tooling:master Feb 13, 2021
@christophebedard christophebedard deleted the pr-repos-files-override-and-supplemental branch February 13, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants