Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated pose2d with pose #64

Merged
merged 5 commits into from
Mar 16, 2022
Merged

replace deprecated pose2d with pose #64

merged 5 commits into from
Mar 16, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Mar 15, 2022 •
edited
Loading

Pose2D is deprecated in geometry_msgs, so use Pose.
Alternative would be to have x, y, theta as fields of BoundingBox2d.msg and not depend on geometry_msgs/Pose2D.

Resolves: #65

@SteveMacenski
Copy link
Member

This seems perfectly reasonable. However, I'd like to hold off until I re-engage with folks on ros2/common_interfaces#179 to see if we can't keep the message around.

@SteveMacenski SteveMacenski mentioned this pull request Mar 16, 2022
Closed
@ijnek
add Pose2D.msg
274aaa7 
Signed-off-by: Kenji Brameld <[email protected]>
@ijnek
Copy link
Member Author

ijnek commented Mar 16, 2022

@SteveMacenski updated accordingly.

@ijnek ijnek marked this pull request as draft March 16, 2022 01:33
@ijnek
undo some changes made
eff82c0 
Signed-off-by: Kenji Brameld <[email protected]>
@ijnek ijnek marked this pull request as ready for review March 16, 2022 01:35
SteveMacenski
SteveMacenski approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveMacenski
Copy link
Member

@Kukanani do you want to take a look

Kukanani
Kukanani reviewed Mar 16, 2022
View reviewed changes
msg/Pose2D.msg Outdated Show resolved Hide resolved
Kukanani
Kukanani approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@Kukanani Kukanani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how fast y'all are. One nit to be explicit with documentation, otherwise, looks great.

@ijnek @Kukanani
Update msg/Pose2D.msg
9531cf6 
Co-authored-by: Adam Allevato <[email protected]>
@SteveMacenski SteveMacenski merged commit 4f8141f into ros-perception:ros2 Mar 16, 2022
@ijnek ijnek deleted the ijnek-deprecated-pose2d branch March 16, 2022 03:28
@ijnek ijnek mentioned this pull request Mar 16, 2022
Closed
@tfoote tfoote mentioned this pull request Mar 16, 2022
Open
@ijnek ijnek mentioned this pull request Mar 16, 2022
Closed
@ijnek ijnek mentioned this pull request Mar 30, 2022
Closed
@SteveMacenski SteveMacenski mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@Kukanani Kukanani Kukanani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijnek @SteveMacenski @Kukanani