Add a GitLab manifest provider #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikepurvis, are you still interested in GitLab support here? Any chance you can give me a hand in testing this and updating it to work with on-prem URLs? |
|
@cottsay Sorry I missed this tag. I no longer needed this as we implement our own asyncio version of this kind of thing, see: https://github.com/clearpathrobotics/colcon-distro/blob/main/colcon_distro/download.py#L139-L155 But hopefully it can be useful to someone else. |
|
I've updated this PR to support self-hosted GitLab based on a host beginning with Ready for review. |
nuclearsandwich
approved these changes
Nov 27, 2024
Co-authored-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing and authentication support