Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build metadata in the version string by appending a plus sign #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow build metadata in the version string by appending a plus sign #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/catkin_pkg/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def validate(self, warnings=None):
'Package name "%s" does not follow the naming conventions. It should start with '
'a lower case letter and only contain lower case letters, digits, underscores, and dashes.' % self.name)

version_regexp = r'^[0-9]+\.[0-9]+\.[0-9]+$'
version_regexp = r'^[0-9]+\.[0-9]+\.[0-9]+(\+[a-zA-Z0-9_.-]+)?$'
if not self.version:
errors.append('Package version must not be empty')
elif not re.match(version_regexp, self.version):
Expand Down