-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GP8 OPW parameters #493
base: kinetic-devel
Are you sure you want to change the base?
Conversation
cjue
commented
Apr 13, 2022
- add opw file
- fix link2 collision mesh
- add flange link
- update reference documentation
- minor fix for velocity limits
@cjue: I submitted isys-vision#6 to add 132d728. Please review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a downsampled version of the visual
mesh?
(just noticed the visual
mesh is 1MB+. Not sure what happened during the review when that was initially contributed ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might have been from a 3D model that included a lot of internal elements which makes if harder reduce but still keep details. I should be able to generate new .dae model by converting MotoSim models that are already reduced.
@gavanderhoorn Do you want me to do it on this PR, or it's probably better to create a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, no need.
It's already in the history of the repository, so adding a newer version will not reduce the total size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as requested changes.