Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve has_realtime_kernel method #260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

These changes allow the detection of realtime kernel even from the uname output. It should be more robust.

Fixes: #257

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (db891ef) to head (233e1fd).

Files with missing lines Patch % Lines
src/realtime_helpers.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   70.12%   69.13%   -0.99%     
==========================================
  Files           8        8              
  Lines         492      499       +7     
  Branches       84       86       +2     
==========================================
  Hits          345      345              
- Misses         92       99       +7     
  Partials       55       55              
Flag Coverage Δ
unittests 69.13% <0.00%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/realtime_helpers.cpp 37.14% <0.00%> (-2.66%) ⬇️

@alexswerner
Copy link

I think the approach is OK, but one thought:

  • using #if !defined(_WIN32) on a feature which is Linux specific might be the wrong test

Hopefully the kernel uname output will always include this.

@saikishor
Copy link
Member Author

@alexswerner yes! I had to do that to make the Windows CI work. If not, it doesn't compile at all. Maybe, I can fix it differently

@saikishor
Copy link
Member Author

@alexswerner done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PREEMPT_RT detection on kernel 6.12
4 participants