-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve has_realtime_kernel method #260
base: master
Are you sure you want to change the base?
Improve has_realtime_kernel method #260
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 70.12% 69.13% -0.99%
==========================================
Files 8 8
Lines 492 499 +7
Branches 84 86 +2
==========================================
Hits 345 345
- Misses 92 99 +7
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think the approach is OK, but one thought:
Hopefully the kernel uname output will always include this. |
@alexswerner yes! I had to do that to make the Windows CI work. If not, it doesn't compile at all. Maybe, I can fix it differently |
@alexswerner done! |
These changes allow the detection of realtime kernel even from the
uname
output. It should be more robust.Fixes: #257