Apply suggestions from code review

Co-authored-by: Christoph Fröhlich <[email protected]>
ros-controls · Jan 2, 2025 · ac7ae53 · ac7ae53
1 parent 356d87e
commit ac7ae53
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/include/realtime_tools/lock_free_queue.hpp b/include/realtime_tools/lock_free_queue.hpp
@@ -201,8 +201,6 @@ class LockFreeQueueBase
   [[nodiscard]] std::enable_if_t<std::is_convertible_v<T, U>, bool> bounded_push(const U & data)
   {
     if (!data_queue_.push(data)) {
-      // data_queue_.pop();
-      // return data_queue_.push(data);
       T dummy;
       data_queue_.pop(dummy);
       return data_queue_.push(data);
@@ -237,8 +235,6 @@ class LockFreeQueueBase
   [[nodiscard]] std::enable_if_t<std::is_convertible_v<T, U>, bool> bounded_push(const U & data)
   {
     if (!data_queue_.bounded_push(data)) {
-      // data_queue_.pop();
-      // return data_queue_.push(data);
       T dummy;
       data_queue_.pop(dummy);
       return data_queue_.bounded_push(data);

diff --git a/package.xml b/package.xml
@@ -19,7 +19,7 @@
 
   <buildtool_export_depend>ament_cmake</buildtool_export_depend>
 
-  <build_depend>libboost-dev</build_depend>
+  <depend>libboost-dev</depend>
   <depend>rclcpp</depend>
   <depend>rclcpp_action</depend>
   <depend>libcap-dev</depend>