Skip to content

Commit

Permalink
Correctly parse the new Windows binaries names
Browse files Browse the repository at this point in the history
Before this improvement root-project/root@1998f73
they had names like "root_v6.35.01.win64.vc17.zip". After this improvement,
i.e. 2024-11-7, "root_v6.35.01.win64.python311.vc17.zip" i.e. they
encode the python version.
  • Loading branch information
dpiparo committed Nov 14, 2024
1 parent f8f43f5 commit d3cd565
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions _releases/make-release-page.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,12 @@ def binaryNameToTitle(filename):

return F"macOS {macOSVers} {arch} Xcode {xcodeVers}"
elif platformCompiler.startswith('win32') or platformCompiler.startswith('win64'):
regexWin = re.compile(r'^win(32|64)[.](vc[0-9]+)(.debug)?')
regexWin = re.compile(r'^win(32|64)[.](python3[0-9]+)[.](vc[0-9]+)(.debug)?')
matchWin = regexWin.match(platformCompiler)
if not matchWin:
print(F'ERROR: cannot parse Win32 MSVC version for {filename}')
return filename
(bitness, vcVers, debug) = matchWin.groups()
(bitness, pythonVers, vcVers, debug) = matchWin.groups()
if not debug:
debug = ''
else:
Expand All @@ -291,7 +291,7 @@ def binaryNameToTitle(filename):
bitArch = "x86"
else:
bitArch = "x64"
return F"Windows Visual Studio {versYear} {bitness}-bit {bitArch} {debug}"
return F"Windows Visual Studio {versYear} {bitness}-bit {bitArch}{debug}"
else:
frameinfo = getframeinfo(currentframe())
print(F'ERROR: unknown platform {platformCompiler} for {filename}. Please edit {frameinfo.filename}:{frameinfo.lineno}')
Expand Down

0 comments on commit d3cd565

Please sign in to comment.