Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawing of TMultiGraph axes #17631

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Fix drawing of TMultiGraph axes #17631

merged 2 commits into from
Feb 6, 2025

Conversation

linev
Copy link
Member

@linev linev commented Feb 5, 2025

Reset Sumw2 array of histogram to avoid baseline drawing at position 0.

Solves #17470

@linev linev requested a review from couet February 5, 2025 15:04
@linev linev self-assigned this Feb 5, 2025
@linev linev requested a review from lmoneta as a code owner February 5, 2025 15:04
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented Feb 5, 2025

Test Results

    18 files      18 suites   4d 15h 0m 53s ⏱️
 2 690 tests  2 684 ✅ 0 💤  6 ❌
46 724 runs  46 714 ✅ 0 💤 10 ❌

For more details on these failures, see this check.

Results for commit a0b1b53.

♻️ This comment has been updated with latest results.

@linev linev changed the title Fix drawing of TMultiGraph axes Fix drawing of TMultiGraph axes [DO NOT MERGE]! Feb 6, 2025
@linev
Copy link
Member Author

linev commented Feb 6, 2025

Use of "AXIS" is not correct, title and grid is not drawn in this case.
I need to check again.

@linev linev changed the title Fix drawing of TMultiGraph axes [DO NOT MERGE]! Fix drawing of TMultiGraph axes Feb 6, 2025
@linev
Copy link
Member Author

linev commented Feb 6, 2025

I rebase PR and now simply reset Sumw2 array of histogram

@linev linev closed this Feb 6, 2025
@linev linev reopened this Feb 6, 2025
@linev linev merged commit 9b16969 into root-project:master Feb 6, 2025
17 of 41 checks passed
@linev linev deleted the mg_axis branch February 6, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants