Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMessage honour kIsOwner bit when compression is used #17628

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Feb 5, 2025

This Pull request:

Changes or fixes:

Rebased version of #17601

Fixes #14557 reported by @cpulvermacher

Copy link

github-actions bot commented Feb 5, 2025

Test Results

    18 files      18 suites   4d 2h 35m 47s ⏱️
 2 690 tests  2 689 ✅ 0 💤 1 ❌
46 724 runs  46 723 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 5f65a22.

♻️ This comment has been updated with latest results.

net/net/src/TMessage.cxx Outdated Show resolved Hide resolved
net/net/src/TMessage.cxx Outdated Show resolved Hide resolved
@ferdymercury ferdymercury requested a review from pcanal February 5, 2025 22:25
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@dpiparo dpiparo merged commit 124c7f1 into root-project:master Feb 6, 2025
18 of 21 checks passed
@cpulvermacher
Copy link
Contributor

You guys made my day, thank you! 🙂

@ferdymercury ferdymercury deleted the kisowner branch February 6, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ROOT-4550] TMessage doesn't honour kIsOwner bit when compression is used
5 participants