[cppyy] Sync cppyy_backend/loader.py with upstream
#17627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
changed the title
load_cpp_backend with upsteam backend
vepadulano
approved these changes
Feb 5, 2025
vepadulano
requested changes
Feb 5, 2025
guitargeek
force-pushed
the
9725
branch
2 times, most recently
from
68635bb to
fce6e1a
Compare
vepadulano
reviewed
Feb 5, 2025
Test Results 18 files 18 suites 4d 0h 9m 10s ⏱️ For more details on these failures, see this check. Results for commit fce6e1a. |
guitargeek
changed the title
load_cpp_backend with upsteam backendcppyy_backend/loader.py with upstream
To further reduce the code divergence. The patch for `macOS` is still required, but it is updated and renamed to make clear that it's not only relevant for macOS 12.
Remove patches that were either merged upstream or that are not necessary anymore.
vepadulano
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts commit 834f8f3 and move setting the hardcoded cppyy backend
path to the ROOT module, to get rid of a patch.
Sync the
load_cpp_backendfunction with upsteam while at it.