-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ntuple] Merger: don't abort if a file doesn't contain a RNTuple #17609
base: master
Are you sure you want to change the base?
Conversation
c0bebf3
to
c9c75a2
Compare
Test Results 17 files 17 suites 4d 1h 26m 40s ⏱️ For more details on these failures, see this check. Results for commit 63b95b8. ♻️ This comment has been updated with latest results. |
In principle LGTM, we probably want a test for this, in |
But "don't abort" is present imperative; am I missing something? |
You are right. I thought we also prefer positive message instead negations (well, at least I do), but then please disregard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; please add a test, I'd suggest a unit test in ntuple_merger using TFileMerger
.
This mirrors the merge behavior of other ROOT objects
c9c75a2
to
63b95b8
Compare
The file without the RNTuple will simply be skipped. This mirrors the merge behavior of other ROOT objects.
Note that if the user gave the -ff or -fk options ("use first source compression") the compression will be taken from the first RNTuple found.
Checklist: