[ntuple] Fix-up read options #17574
Open
[ntuple] Fix-up read options #17574
+51
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has been useful for performance studies. It specifies the
number of clusters to be preloaded in the cluster cache. Since the size
of clusters is a priori unknown, this option is not well suited as a
general interface. Eventually, the option will be replaced by a prefetch
setting based on available memory ("prefill at max x MB").
silverweed
approved these changes
Jan 30, 2025
hahnjo
reviewed
Jan 30, 2025
Test Results 18 files 18 suites 4d 3h 34m 2s ⏱️ For more details on these failures, see this check. Results for commit 22fb187. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-fix-read-options
branch
from
306b4b5 to
22fb187
Compare
hahnjo
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for moving read options out of experimental.