[ntuple] rename RHeaderExtension::AddExtended* to MarkExtended* #17561
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enirolf
approved these changes
Jan 29, 2025
Test Results 18 files 18 suites 4d 23h 8m 8s ⏱️ For more details on these failures, see this check. Results for commit ffe77fb. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_desc_mark
branch
from
83645d8 to
ffe77fb
Compare
jblomer
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulted from an offline discussion with Jakob: the word "add" is a bit ambiguous because we already Add the extended columns/fields to the descriptor, but we also mark them as extended if we're extending the header.