Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix purge_osd command for multiple OSD IDs #341

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

troyApart
Copy link
Contributor

Updating the command pre run to parse
the comma separated list of OSD IDs

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Collaborator

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing multiple osd at once sounds good to me.

Just tagging @travisn to get your feedback.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion

cmd/commands/rook.go Outdated Show resolved Hide resolved
@troyApart troyApart force-pushed the fix-purge-osds-multiple branch from 020b25d to db47807 Compare November 26, 2024 19:58
Updating the command pre run to parse
the comma separated list of OSD IDs

Signed-off-by: Troy Partridge <[email protected]>
@troyApart troyApart force-pushed the fix-purge-osds-multiple branch from db47807 to b80a930 Compare November 26, 2024 20:02
@travisn travisn merged commit f52bd95 into rook:master Nov 26, 2024
6 checks passed
@troyApart troyApart deleted the fix-purge-osds-multiple branch November 26, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants