clean: Ensure cephcluster cleanup job runs #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
force-pushed
the
cleanup-policy-apply
branch
from
5f5dabb to
eb70ba8
Compare
subhamkrai
reviewed
Apr 5, 2024
There was a problem hiding this comment.
@travisn is this ready for review or you are still exploring the fix?
Thanks
The fix looks good in the local testing, there just seems to be a CI issue that I'm still looking at. |
travisn
force-pushed
the
cleanup-policy-apply
branch
3 times, most recently
from
7ead254 to
206a9c6
Compare
During the destroy-cluster, if there are any osd-prepare jobs they will be purged, similar to deployments that are not being purged automatically. Signed-off-by: Travis Nielsen <[email protected]>
The cleanup policy was not allowed to take effect during the cluster cleanup. The finalizer was immediately be removed instead of remaining until the operator has a chance to handle the cleanup policy and internally remove the finalizer. Now the cleanup policy is allowed to be applied and the cleanup job(s) will be started to cleanup the host path and disks from OSDs. Signed-off-by: Travis Nielsen <[email protected]>
travisn
force-pushed
the
cleanup-policy-apply
branch
from
206a9c6 to
a73bf5e
Compare
|
@subhamkrai Ready for final review, the CI is passing now, after rebasing. Such an old PR! Time to enable the stale bot... |
subhamkrai
approved these changes
Oct 28, 2024
Will check on adding the bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The cleanup policy was not allowed to take effect during the cluster cleanup. The finalizer was immediately be removed instead of remaining until the operator has a chance to handle the cleanup policy and internally remove the finalizer. Now the cleanup policy is allowed to be applied and the cleanup job(s) will be started to cleanup the host path and disks from OSDs.
Checklist: