fix: Do not fail when OIDC server application URL has a trailing slash #1440
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `authlib` util `get_well_known_url` to get the well-known URL for the OIDC server metadata. This will ensure that the URL is correctly formatted and does not fail when the OIDC server application URL has a trailing slash. Fixes #1430.
Test Results91 tests 91 ✅ 27s ⏱️ Results for commit 47fb3bd. |
zurdi15
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
authlibutilget_well_known_urlto get the well-known URL for the OIDC server metadata. This will ensure that the URL is correctly formatted and does not fail when the OIDC server application URL has a trailing slash.Fixes #1430.