-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix tinfoil issue with improper rom DL urls and support for rom folders #1316
base: master
Are you sure you want to change the base?
fix: Fix tinfoil issue with improper rom DL urls and support for rom folders #1316
Conversation
Added a few more updates to address the following:
|
) | ||
), | ||
size=rom.file_size_bytes, | ||
size=rom.files[0].get('size'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rom.files[0]
here now needs to be file
, after the latest changes.
) | ||
for rom in roms | ||
for rom in roms if rom.files and len(rom.files) > 0 | ||
for file in rom.files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to expose all files to Tinfoil. Ideally, we could only include the ones with a valid extension that Tinfoil understands (in case users maintain other kind of resources within the rom folder).
@KaitoKid, please let us know if you plan to keep updating this PR. |
Addresses the concerns in #1208
Tinfoil Parsing Issues
Root cause is the FS handler for get_roms assumes that directories with a single file inside as
multi
which results in the following FSRom being created after the directory is scanned
This fix addresses two things:
multi
file_name
. Instead, it renames the file in Tinfoil to thefile_name
instead.Known Bugs
Since this takes just the first obj of each rom file, it cannot handle cases where multiple files are stored in one directory. I'll defer to the community on the best method of handling this, but a couple ideas come to mind: