Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code s1e1 #126

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
+320 −277
Open

Clean code s1e1 #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f3a6588
fix: add spaces to html 1.1. Indentation
Nerzula Dec 16, 2024
a9357a8
refactor: change spaces from 4 to 2 in style.css 1.1. Indentation
Nerzula Dec 16, 2024
14d66d7
refactor: change spaces from 4 to 2 in js 1.1. Indentation
Nerzula Dec 16, 2024
7cac8c6
fix: change uppercase to lowercase in html and css 1.2. Use lowercase
Nerzula Dec 17, 2024
4b8999c
fix: change single quotes to double quotes 1.3. Quotes in HTML & CSS…
Nerzula Dec 17, 2024
cba3cfe
feat: add 2.2. Document Type
Nerzula Dec 17, 2024
c91fc9c
fix: 2.3. Named character references
Nerzula Dec 17, 2024
5a494fd
fix: remove type attribute 2.4. 'type' attribute
Nerzula Dec 17, 2024
1904c7a
fix: change class adn id 3.1. Single style for selectors naming
Nerzula Dec 17, 2024
bc604e4
refactor: change class name use BEM 3.2. Meaningful naming of identif…
Nerzula Dec 17, 2024
2c9e6a0
fix: change class name 3.3. Keep the names of identifiers and classes…
Nerzula Dec 17, 2024
321388d
fix: change class name
Nerzula Dec 17, 2024
c948823
refactor: remove tag selector toggle class name 3.4. Tag selectors
Nerzula Dec 17, 2024
5ab9067
fix: add space and semicolon 3.6. Space after property name
Nerzula Dec 17, 2024
bebd055
fix: add spaces between class selectors
Nerzula Dec 17, 2024
2597011
refactor: change tags to semantics tags 1.1. Semantics
Nerzula Dec 17, 2024
5cacbfe
feat: add 1.2. Media alternatives
Nerzula Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
284 changes: 131 additions & 153 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,191 +5,169 @@
//Solution: Add interactivity so the user can manage daily tasks.
//Break things down into smaller steps and take each step at a time.


// Event handling, user interaction is what starts the code execution.

var taskInput=document.getElementById("new-task");//Add a new task.
var addButton=document.getElementsByTagName("button")[0];//first button
var incompleteTaskHolder=document.getElementById("incompleteTasks");//ul of #incompleteTasks
var completedTasksHolder=document.getElementById("completed-tasks");//completed-tasks

var taskInput = document.getElementById('new-task'); //Add a new task.
var addButton = document.getElementsByTagName('button')[0]; //first button
var incompleteTaskHolder = document.getElementById('incomplete-tasks'); //ul of #incompleteTasks
var completedTasksHolder = document.getElementById('completed-tasks'); //completed-tasks

//New task list item
var createNewTaskElement=function(taskString){

var listItem=document.createElement("li");

//input (checkbox)
var checkBox=document.createElement("input");//checkbx
//label
var label=document.createElement("label");//label
//input (text)
var editInput=document.createElement("input");//text
//button.edit
var editButton=document.createElement("button");//edit button

//button.delete
var deleteButton=document.createElement("button");//delete button
var deleteButtonImg=document.createElement("img");//delete button image

label.innerText=taskString;
label.className='task';

//Each elements, needs appending
checkBox.type="checkbox";
editInput.type="text";
editInput.className="task";

editButton.innerText="Edit"; //innerText encodes special characters, HTML does not.
editButton.className="edit";

deleteButton.className="delete";
deleteButtonImg.src='./remove.svg';
deleteButton.appendChild(deleteButtonImg);


//and appending.
listItem.appendChild(checkBox);
listItem.appendChild(label);
listItem.appendChild(editInput);
listItem.appendChild(editButton);
listItem.appendChild(deleteButton);
return listItem;
}



var addTask=function(){
console.log("Add Task...");
//Create a new list item with the text from the #new-task:
if (!taskInput.value) return;
var listItem=createNewTaskElement(taskInput.value);
var createNewTaskElement = function (taskString) {
var listItem = document.createElement('li');

//input (checkbox)
var checkBox = document.createElement('input'); //checkbx
//label
var label = document.createElement('label'); //label
//input (text)
var editInput = document.createElement('input'); //text
//button.edit
var editButton = document.createElement('button'); //edit button

//button.delete
var deleteButton = document.createElement('button'); //delete button
var deleteButtonImg = document.createElement('img'); //delete button image

listItem.classList = 'tasks__item';

label.innerText = taskString;
label.className = 'tasks__label';

//Each elements, needs appending
checkBox.type = 'checkbox';
checkBox.className = 'tasks__input';
editInput.type = 'text';
editInput.className = 'tasks__input';

editButton.innerText = 'Edit'; //innerText encodes special characters, HTML does not.
editButton.className = 'tasks__button-edit';

deleteButton.className = 'tasks__button-delete';
deleteButtonImg.src = './remove.svg';
deleteButtonImg.classList = 'tasks__button-delete-img';
deleteButton.appendChild(deleteButtonImg);

//and appending.
listItem.appendChild(checkBox);
listItem.appendChild(label);
listItem.appendChild(editInput);
listItem.appendChild(editButton);
listItem.appendChild(deleteButton);
return listItem;
};

//Append listItem to incompleteTaskHolder
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);
var addTask = function () {
console.log('Add Task...');
//Create a new list item with the text from the #new-task:
if (!taskInput.value) return;
var listItem = createNewTaskElement(taskInput.value);

taskInput.value="";
//Append listItem to incompleteTaskHolder
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);

}
taskInput.value = '';
};

//Edit an existing task.

var editTask=function(){
console.log("Edit Task...");
console.log("Change 'edit' to 'save'");


var listItem=this.parentNode;

var editInput=listItem.querySelector('input[type=text]');
var label=listItem.querySelector("label");
var editBtn=listItem.querySelector(".edit");
var containsClass=listItem.classList.contains("editMode");
//If class of the parent is .editmode
if(containsClass){

//switch to .editmode
//label becomes the inputs value.
label.innerText=editInput.value;
editBtn.innerText="Edit";
}else{
editInput.value=label.innerText;
editBtn.innerText="Save";
}

//toggle .editmode on the parent.
listItem.classList.toggle("editMode");
var editTask = function () {
console.log('Edit Task...');
console.log("Change 'edit' to 'save'");

var listItem = this.parentNode;

var editInput = listItem.querySelector('.tasks__input[type=text]');
var label = listItem.querySelector('.tasks__label');
var editBtn = listItem.querySelector('.tasks__button-edit');
var containsClass = listItem.classList.contains('tasks__item--edit-mode');
//If class of the parent is .editmode
if (containsClass) {
//switch to .editmode
//label becomes the inputs value.
label.innerText = editInput.value;
editBtn.innerText = 'Edit';
} else {
editInput.value = label.innerText;
editBtn.innerText = 'Save';
}

//toggle .editmode on the parent.
listItem.classList.toggle('tasks__item--edit-mode');
};


//Delete task.
var deleteTask=function(){
console.log("Delete Task...");

var listItem=this.parentNode;
var ul=listItem.parentNode;
//Remove the parent list item from the ul.
ul.removeChild(listItem);

}
var deleteTask = function () {
console.log('Delete Task...');

var listItem = this.parentNode;
var ul = listItem.parentNode;
//Remove the parent list item from the ul.
ul.removeChild(listItem);
};

//Mark task completed
var taskCompleted=function(){
console.log("Complete Task...");

//Append the task list item to the #completed-tasks
var listItem=this.parentNode;
completedTasksHolder.appendChild(listItem);
bindTaskEvents(listItem, taskIncomplete);

}


var taskIncomplete=function(){
console.log("Incomplete Task...");
//Mark task as incomplete.
//When the checkbox is unchecked
//Append the task list item to the #incompleteTasks.
var listItem=this.parentNode;
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem,taskCompleted);
}
var taskCompleted = function () {
console.log('Complete Task...');

//Append the task list item to the #completed-tasks
var listItem = this.parentNode;
completedTasksHolder.appendChild(listItem);
bindTaskEvents(listItem, taskIncomplete);
};

var taskIncomplete = function () {
console.log('Incomplete Task...');
//Mark task as incomplete.
//When the checkbox is unchecked
//Append the task list item to the #incompleteTasks.
var listItem = this.parentNode;
incompleteTaskHolder.appendChild(listItem);
bindTaskEvents(listItem, taskCompleted);
};

var ajaxRequest=function(){
console.log("AJAX Request");
}
var ajaxRequest = function () {
console.log('AJAX Request');
};

//The glue to hold it all together.


//Set the click handler to the addTask function.
addButton.onclick=addTask;
addButton.addEventListener("click",addTask);
addButton.addEventListener("click",ajaxRequest);


var bindTaskEvents=function(taskListItem,checkBoxEventHandler){
console.log("bind list item events");
//select ListItems children
var checkBox=taskListItem.querySelector("input[type=checkbox]");
var editButton=taskListItem.querySelector("button.edit");
var deleteButton=taskListItem.querySelector("button.delete");


//Bind editTask to edit button.
editButton.onclick=editTask;
//Bind deleteTask to delete button.
deleteButton.onclick=deleteTask;
//Bind taskCompleted to checkBoxEventHandler.
checkBox.onchange=checkBoxEventHandler;
}
addButton.onclick = addTask;
addButton.addEventListener('click', addTask);
addButton.addEventListener('click', ajaxRequest);

var bindTaskEvents = function (taskListItem, checkBoxEventHandler) {
console.log('bind list item events');
//select ListItems children
var checkBox = taskListItem.querySelector('.tasks__input[type=checkbox]');
var editButton = taskListItem.querySelector('.tasks__button-edit');
var deleteButton = taskListItem.querySelector('.tasks__button-delete');

//Bind editTask to edit button.
editButton.onclick = editTask;
//Bind deleteTask to delete button.
deleteButton.onclick = deleteTask;
//Bind taskCompleted to checkBoxEventHandler.
checkBox.onchange = checkBoxEventHandler;
};

//cycle over incompleteTaskHolder ul list items
//for each list item
for (var i=0; i<incompleteTaskHolder.children.length;i++){

//bind events to list items chldren(tasksCompleted)
bindTaskEvents(incompleteTaskHolder.children[i],taskCompleted);
for (var i = 0; i < incompleteTaskHolder.children.length; i++) {
//bind events to list items chldren(tasksCompleted)
bindTaskEvents(incompleteTaskHolder.children[i], taskCompleted);
}




//cycle over completedTasksHolder ul list items
for (var i=0; i<completedTasksHolder.children.length;i++){
//bind events to list items chldren(tasksIncompleted)
bindTaskEvents(completedTasksHolder.children[i],taskIncomplete);
for (var i = 0; i < completedTasksHolder.children.length; i++) {
//bind events to list items chldren(tasksIncompleted)
bindTaskEvents(completedTasksHolder.children[i], taskIncomplete);
}




// Issues with usability don't get seen until they are in front of a human tester.

//prevent creation of empty tasks.

//Change edit to save when you are in edit mode.
//Change edit to save when you are in edit mode.
Loading