Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #387

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add files via upload #387

wants to merge 1 commit into from

Conversation

ortizreyes
Copy link

@ortizreyes ortizreyes commented Nov 11, 2020

Adding the Spanish translation for our TRST580 course.

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Adding the Spanish translation
Copy link
Collaborator

@mihail-varbanov mihail-varbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the exact structure and format of the language translation file. This includes:

  1. The current and updated file should have exactly the same set of entries. This means that:
  • all entries in the current file should persist in the updated;
  • there should not be entries in the updated fie that do persist in the current;
  1. The order of the entries in the current and updated file should be exactly the same;

  2. The JSON formatting of the current and updated file should be exactly the same. This includes:

    • leading tab/spaces to be the same;
    • preserve white spaces (if any) after the column marks;
    • preserve the new lines between logical sections/blocks of entries;
    • preserve the new line format: CR vs LF CR;
  3. If I compare the current and updated file using a file compare utility like FileMerge or GitHub Diff the only difference between them should be the translated strings. All other parts of the files should be exactly the same.

  4. The file should contain a valid JSON content.

The Spanish strings from rules are located in assets/health.rules.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants