Fix sleep_time method in ExceptionRetryPolicy #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change looks right but I'm reluctant to merge it while there are CI issues. Please wait for me to fix CI first. |
|
No problem, thanks! |
|
CI configuration in this repo has been refactored. Could you please rebase this pull request on latest master? |
There is a small discrepancy between documentation and implementation of sleep_time in ExceptionRetryPolicy. We modify the implementation so that it conforms with the docs.
jm-wk
force-pushed
the
sleep_time_fix
branch
from
fea975c to
e235157
Compare
for more information, see https://pre-commit.ci
|
Thanks! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small discrepancy between documentation and implementation of sleep_time in ExceptionRetryPolicy. We modify the implementation so that it conforms with the docs.