Fix InvalidStateError log spam in some cancellation scenarios #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a future has already been cancelled, we can't set the result or exception. It is not an error if this happens to a future cancelled by the caller, so don't generate ERROR logs in that case. Fixes #337
rohanpm
force-pushed
the
reduce-cancel-logspam
branch
from
8a99a8d to
9776e50
Compare
|
Code Climate has analyzed commit 9776e50 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 82.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.5% (-0.2% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a future has already been cancelled, we can't set the result or
exception. It is not an error if this happens to a future cancelled by
the caller, so don't generate ERROR logs in that case.
Fixes #337