Skip to content

Commit

Permalink
pylint: disable signature-differs
Browse files Browse the repository at this point in the history
In Python 3.9, a new keyword argument was added to shutdown().
We will run into this warning everywhere due to that.
It's not yet clear what to do about it, since we can't easily
match the signature both prior to and after that python version.
Let's disable this for now to unblock CI.
  • Loading branch information
rohanpm committed Jun 1, 2020
1 parent 268c8f8 commit d6a3bbb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ disable=
bad-continuation,
# Nothing wrong with a small number of public methods
too-few-public-methods,
# Python 3.9 is changing the signature of Executor.shutdown().
# Not sure how to deal with it yet, but it likely will trigger
# this warning.
signature-differs,


# Enable the message, report, category or checker with the given id(s). You can
Expand Down

0 comments on commit d6a3bbb

Please sign in to comment.