beatthat #152
Open
beatthat #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| "<br>" + | ||
| player1Statement + | ||
| ". <br>" + | ||
| player2Statement + |
There was a problem hiding this comment.
'player2Statement' is not defined.
| "Current Game Mode: " + | ||
| gameMode + | ||
| "<br>" + | ||
| player1Statement + |
There was a problem hiding this comment.
'player1Statement' is not defined.
| if (player2 > player1) { | ||
| message = player2Name + " is leading!"; | ||
| } | ||
| return (myOutputValue = |
There was a problem hiding this comment.
'myOutputValue' is not defined.
| if (player2 > player1) { | ||
| message = player2Name + " is leading!"; | ||
| } | ||
| return (myOutputValue = |
There was a problem hiding this comment.
Return statement should not contain assignment.
| player2Storage = sequence4; | ||
| player2 = player2 + player2Storage; | ||
| } | ||
| player2Statement = |
There was a problem hiding this comment.
'player2Statement' is not defined.
|
Code Climate has analyzed commit 6c9d3e9 and detected 69 issues on this pull request. Here's the issue category breakdown:
Note: there are 52 critical issues. View more on Code Climate. |
Comment on lines
+38
to
+49
| // Enter Player 1 Name | ||
| if (player1Name == "Player1Name") { | ||
| var playerName = enterPlayerName(input); | ||
| player1Name = playerName; | ||
| return player1Name + " has joined the game"; | ||
| } | ||
| // Enter Player 2 Name | ||
| if (player2Name == "Player2Name") { | ||
| var playerName = enterPlayerName(input); | ||
| player2Name = playerName; | ||
| return player2Name + " has joined the game"; | ||
| } |
There was a problem hiding this comment.
smart way of getting players name but it would be better if there is an put invalidation
Comment on lines
+51
to
+60
| if ( | ||
| input == "Normal" || | ||
| input == "Lowest" || | ||
| input == "Auto" || | ||
| playerTurn == "End" | ||
| ) { | ||
| gameMode = input; | ||
| playerTurn = "Player 1"; | ||
| return (myOutputValue = input + " has been selected. Lets begin!"); | ||
| } else myOutputValue = "Choose only Normal, Lowest or Auto~"; |
Comment on lines
+67
to
+83
| // player1 turn | ||
| if (playerTurn == "Player 1") { | ||
| var diceRoll1 = randomDiceRoll(); | ||
| var diceRoll2 = randomDiceRoll(); | ||
| dice1 = diceRoll1; // storing player 1 numbers into global | ||
| dice2 = diceRoll2; | ||
| myOutputValue = | ||
| player1Name + | ||
| " has rolled " + | ||
| dice1 + | ||
| " and " + | ||
| dice2 + | ||
| ". <br> Select the sequence."; | ||
| sequenceToggle = "ON"; | ||
| playerTurn = "Player 1 Sequence Toggle"; | ||
| return myOutputValue; | ||
| } |
There was a problem hiding this comment.
player 1 roll dice and player 2 roll dice are the same logic. You could refactor it into a function and reuse it instead of rewriting the same logic
Comment on lines
+85
to
+99
| if (sequenceToggle == "ON" && playerTurn == "Player 1 Sequence Toggle") { | ||
| if (input == "1") { | ||
| var sequence1 = selectSequence1(dice1, dice2); | ||
| player1Storage = sequence1; | ||
| player1 = player1 + player1Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 2"; | ||
| } | ||
| if (input == "2") { | ||
| var sequence2 = selectSequence2(dice2, dice1); | ||
| player1Storage = sequence2; | ||
| player1 = player1 + player1Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 2"; | ||
| } |
There was a problem hiding this comment.
same as above , repeated code could be refactor with function helper and reuse it for both player 1 and player 2
Comment on lines
+102
to
+134
| if (playerTurn == "Player 2") { | ||
| var diceRoll1 = randomDiceRoll(); | ||
| var diceRoll2 = randomDiceRoll(); | ||
| dice1 = diceRoll1; // storing player 2 numbers into global | ||
| dice2 = diceRoll2; | ||
| myOutputValue = | ||
| player2Name + | ||
| " has rolled " + | ||
| dice1 + | ||
| " and " + | ||
| dice2 + | ||
| ". <br> Select the sequence."; | ||
| sequenceToggle = "ON"; | ||
| playerTurn = "Player 2 Sequence Toggle"; | ||
| return myOutputValue; | ||
| } | ||
| // player 2 selection | ||
| if (sequenceToggle == "ON" && playerTurn == "Player 2 Sequence Toggle") { | ||
| if (input == "1") { | ||
| var sequence1 = selectSequence1(dice1, dice2); | ||
| player2Storage = sequence1; | ||
| player2 = player2 + player2Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 1"; | ||
| } | ||
| if (input == "2") { | ||
| var sequence2 = selectSequence2(dice2, dice1); | ||
| player2Storage = sequence2; | ||
| player2 = player2 + player2Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 1"; | ||
| } | ||
| } |
Comment on lines
+202
to
+261
| if (playerTurn == "Player 2") { | ||
| var diceRoll1 = randomDiceRoll(); | ||
| var diceRoll2 = randomDiceRoll(); | ||
| dice1 = diceRoll1; // storing player 2 numbers into global | ||
| dice2 = diceRoll2; | ||
| myOutputValue = | ||
| player2Name + | ||
| " has rolled " + | ||
| dice1 + | ||
| " and " + | ||
| dice2 + | ||
| ". <br> Select the sequence."; | ||
| sequenceToggle = "ON"; | ||
| playerTurn = "Player 2 Sequence Toggle"; | ||
| return myOutputValue; | ||
| } | ||
| // player 2 selection | ||
| if (sequenceToggle == "ON" && playerTurn == "Player 2 Sequence Toggle") { | ||
| if (input == "1") { | ||
| var sequence1 = selectSequence1(dice1, dice2); | ||
| player2Storage = sequence1; | ||
| player2 = player2 + player2Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 1"; | ||
| } | ||
| if (input == "2") { | ||
| var sequence2 = selectSequence2(dice2, dice1); | ||
| player2Storage = sequence2; | ||
| player2 = player2 + player2Storage; | ||
| sequenceToggle = "OFF"; | ||
| playerTurn = "Player 1"; | ||
| } | ||
| } | ||
| // compare winners and message | ||
| var message = ""; | ||
| if (player1 == player2) { | ||
| message = "Score is tied now"; | ||
| } | ||
| if (player1 < player2) { | ||
| message = player1Name + " is leading the losing race!"; | ||
| } | ||
| if (player2 < player1) { | ||
| message = player2Name + " is leading the losing race!"; | ||
| } | ||
| return ( | ||
| "Current Game Mode: " + | ||
| gameMode + | ||
| "<br>" + | ||
| message + | ||
| "<br>" + | ||
| player1Name + | ||
| " score now is " + | ||
| player1 + | ||
| "<br>" + | ||
| player2Name + | ||
| " score now is " + | ||
| player2 + | ||
| "<br> Next Round." | ||
| ); | ||
| } |
Comment on lines
+273
to
+280
| if (dice1 > dice2) { | ||
| var sequence1 = selectSequence1(dice1, dice2); | ||
| player1Storage = sequence1; | ||
| player1 = player1 + player1Storage; | ||
| } else { | ||
| var sequence2 = selectSequence2(dice2, dice1); | ||
| player1Storage = sequence2; | ||
| player1 = player1 + player1Storage; |
There was a problem hiding this comment.
smart way of getting the sequence
Comment on lines
+274
to
+278
| var sequence1 = selectSequence1(dice1, dice2); | ||
| player1Storage = sequence1; | ||
| player1 = player1 + player1Storage; | ||
| } else { | ||
| var sequence2 = selectSequence2(dice2, dice1); |
There was a problem hiding this comment.
selectSequence1 and selectSequence2 are using the same logic , reuse it instead of creating a new function that does the same thing
Comment on lines
+292
to
+304
| var diceRoll3 = randomDiceRoll(); | ||
| var diceRoll4 = randomDiceRoll(); | ||
| dice3 = diceRoll3; // storing player 2 numbers into global | ||
| dice4 = diceRoll4; | ||
| if (dice3 > dice4) { | ||
| var sequence3 = selectSequence1(dice3, dice4); | ||
| player2Storage = sequence3; | ||
| player2 = player2 + player2Storage; | ||
| } else { | ||
| var sequence4 = selectSequence2(dice4, dice3); | ||
| player2Storage = sequence4; | ||
| player2 = player2 + player2Storage; | ||
| } |
Comment on lines
+316
to
+324
| if (player1 == player2) { | ||
| message = "Score is tied now"; | ||
| } | ||
| if (player1 > player2) { | ||
| message = player1Name + " is leading!"; | ||
| } | ||
| if (player2 > player1) { | ||
| message = player2Name + " is leading!"; | ||
| } |
There was a problem hiding this comment.
repeated code could be refactor and reuse for all the game mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
3hrs
Please fill in one error and/or error message you received while working on this assignment.
unable to string the 2 dice rolls together.
What part of the assignment did you spend the most time on?
stringing the 2 numbers together
Comfort Level (1-5):
3
Completeness Level (1-5):
3
What did you think of this deliverable?
Manageable.
Is there anything in this code that you feel pleased about?
NA