Gloria-beatthat #148
Gloria-beatthat #148
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| rollDice2 = randomDigit(); | ||
| myOutputValue = `Player 2, your Dice 1 is ${rrollDice1} and Dice 2 is ${rollDice2}. <br><br> Please indicate either '1' or '2' to choose the order of your dice.<br><br> User with the highest number will win. Good luck!`; | ||
| gameMode = "pick_dice_order"; | ||
| return myOutputValue; |
There was a problem hiding this comment.
Parsing error: 'return' outside of function
There was a problem hiding this comment.
Please delete unnecessary code
| } | ||
| if (gameModeOrder == "pick_dice_order") { | ||
| if (currentPlayer == 1) { | ||
| if (input == "1") { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return myOutputValue; | ||
| }; | ||
| if (gameMode == "start_the_game") { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| gameMode = "start_the_game"; | ||
| currentPlayer = 2; | ||
| } else if (currentPlayer == 2) { | ||
| if (input == "1") { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| var main = function (input) { | ||
| var myOutputValue = 'hello world'; | ||
| var myOutputValue = ""; | ||
| if (gameMode == "start_the_game") { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit f7f4669 and detected 7 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. View more on Code Climate. |
| if (gameMode == "start_the_game") { | ||
| diceRoll1 = genDiceRoll(); | ||
| diceRoll2 = genDiceRoll(); | ||
| myOutputValue = `Player 1, your Dice 1 is ${diceRoll1} and <br> Dice 2 🎲is ${diceRoll2}. <br><br> Please indicate either '1' or '2' to choose the order of your dice.<br><br> User with the highest number will win. Good luck!`; |
There was a problem hiding this comment.
Good work crafting an output that clearly guides the player on what to do next!
| myOutputValue = `You have chosen Dice 1 and your number is ${diceRoll1}${diceRoll2}.`; | ||
| } | ||
| } else if (input == "2") { | ||
| myOutputValue = `You have chosen Dice 2 and your number is ${diceRoll2}${diceRoll1}.`; |
There was a problem hiding this comment.
There should be something like player1Choice = ${diceRoll2}${diceRoll1} here as well, similar to line 36.
| console.log("player2Choice"); | ||
| myOutputValue = `You have chosen Dice 1 and your number is ${diceRoll1}${diceRoll2}.`; | ||
| } else if (input == "2") { | ||
| myOutputValue = `You have chosen Dice 2 and your number is ${diceRoll2}${diceRoll1}.`; |
There was a problem hiding this comment.
There should be something like player1Choice = ${diceRoll2}${diceRoll1} here as well, similar to line 47.
| } else if (player1Choice < player2Choice) { | ||
| myOutputValue = `Player 1, your score is ${player1Choice} and Player 2, your score is ${player2Choice}. <br><br>Player 2, you win! Yay`; | ||
| } | ||
| return myOutputValue; |
There was a problem hiding this comment.
Do consider a tie condition too!
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
5
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
understanding the logic
Comfort Level (1-5):
2
Completeness Level (1-5):
2
What did you think of this deliverable?
challenging
Is there anything in this code that you feel pleased about?
not really