Beat That: Base + Score + Leaderboard_unfinished #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| "<br></br> The current leaderboard is as follows <br></br> " + | ||
| dashboardDisplay(); | ||
| } | ||
| return display; |
| } else if (gameMode == pending_result) { | ||
| console.log("game mode", gameMode); | ||
| // if pass player settings display the win logic | ||
| display = |
| console.log("game mode", gameMode); | ||
| // if pass dicerollresult then run the player settings | ||
| display = playerSettings(input); | ||
| } else if (gameMode == pending_result) { |
There was a problem hiding this comment.
Identifier 'pending_result' is not in camel case.
| } else if (gameMode == dice_rolled) { | ||
| console.log("game mode", gameMode); | ||
| // if pass dicerollresult then run the player settings | ||
| display = playerSettings(input); |
| console.log("game mode", gameMode); | ||
| // when the setting is now waiting for players, click submit then roll dice result | ||
| display = diceRollResult(); | ||
| } else if (gameMode == dice_rolled) { |
There was a problem hiding this comment.
Identifier 'dice_rolled' is not in camel case.
|
Code Climate has analyzed commit ebedbad and detected 44 issues on this pull request. Here's the issue category breakdown:
Note: there are 38 critical issues. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
2 hours (excluding online research)
Please fill in one error and/or error message you received while working on this assignment.
Missing syntax errors and getting confuse on how to place the if statement within If statement.
What part of the assignment did you spend the most time on?
I think trying to put them in a way where it works step by step, by assigning it into different modes. And syntax errors.
Comfort Level (1-5):
2.5
Completeness Level (1-5):
2.5~3/5
What did you think of this deliverable?
Is there anything in this code that you feel pleased about?
I like that I know how to use global variable properly now