basics beat that #145
Open
basics beat that #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| " Player 2 has rolled " + | ||
| player2Result + | ||
| "<br><br>" + | ||
| winner + |
| "Player 1 has rolled " + | ||
| player1Result + | ||
| " Player 2 has rolled " + | ||
| player2Result + |
There was a problem hiding this comment.
'player2Result' is not defined.
|
|
||
| return ( | ||
| "Player 1 has rolled " + | ||
| player1Result + |
There was a problem hiding this comment.
'player1Result' is not defined.
| } else if (player2Result > player1Result) { | ||
| winner = "player 2 wins"; | ||
| } else { | ||
| winner = "it's a tie!"; |
| var player2DICEROLL = []; | ||
|
|
||
| //game modes | ||
| var mode_DICE_ROLL = "mode_DICE_ROLL"; |
There was a problem hiding this comment.
Identifier 'mode_DICE_ROLL' is not in camel case.
|
Code Climate has analyzed commit 7850a54 and detected 49 issues on this pull request. Here's the issue category breakdown:
Note: there are 43 critical issues. View more on Code Climate. |
eddiejpot
reviewed
Aug 4, 2021
Comment on lines
+131
to
+132
| player1Result = player1DICEROLL.join((seperator = " ")); //to join and remove separator | ||
| player2Result = player2DICEROLL.join((seperator = " ")); |
Comment on lines
+141
to
+142
| player1DICEROLL = []; | ||
| player2DICEROLL = []; |
There was a problem hiding this comment.
Is this used to 'restart' the game ?
If so, it'll be cleaner to have a function that handles the restarting of the game :) !
Comment on lines
+25
to
+39
| //to set current player with Dice Roll | ||
| var playerDiceRolls = function () { | ||
| console.log("worked"); | ||
| //Assigning dice rolls to player | ||
| //if player = 1 | ||
| if (currentPlayer == 1) { | ||
| player1DICEROLL = [randomDiceNumber(), randomDiceNumber()]; | ||
| console.log(player1DICEROLL); | ||
| } | ||
| //if player != 1, it is player 2 | ||
| else { | ||
| player2DICEROLL = [randomDiceNumber(), randomDiceNumber()]; | ||
| console.log(player2DICEROLL); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Good job with handling the diceRolls in 1 function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
Comfort Level (1-5): 5
Completeness Level (1-5): 2
What did you think of this deliverable? the order of steps
Is there anything in this code that you feel pleased about? the neatness