Beat That #138
Beat That #138
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return `It is a draw! Have another go!`; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Newline required at end of file but not found.
| return `Congratulations Player 2! You have won! <br> Player 2 had ${player2Order} and Player 1 had ${player1Order} <br><br> Leaderboard: <br> Player 1: ${player1Win} <br> vs <br> Player 2: ${player2Win} <br> <br> Press submit to play again!`; | ||
| } | ||
| if ( | ||
| player2Order = player1Order |
There was a problem hiding this comment.
Unexpected assignment within an 'if' statement.
| activePlayer = player2; | ||
| gameMode = diceRollMode; | ||
| return `${gameDiceOrder} <br> <br> Now it is player 2's turn! <br> <br> Player 2, press submit to roll.`; | ||
| } else { |
There was a problem hiding this comment.
Unnecessary 'else' after 'return'.
| if (gameMode == diceOrderMode) { | ||
| var gameDiceOrder = diceOrder(input); | ||
| if (input != 1 && input != 2){ | ||
| return `Please input 1 or 2.` |
| } | ||
| if (gameMode == diceOrderMode) { | ||
| var gameDiceOrder = diceOrder(input); | ||
| if (input != 1 && input != 2){ |
There was a problem hiding this comment.
Missing space before opening brace.
|
Code Climate has analyzed commit f1b91ad and detected 15 issues on this pull request. Here's the issue category breakdown:
Note: there are 9 critical issues. View more on Code Climate. |
| var diceRollMode = "dice rolling!"; | ||
| var diceOrderMode = "choose the order of dice"; | ||
| var beatThatWinner = "comparing the numbers"; | ||
| //default game mode | ||
| var gameMode = diceRollMode; |
There was a problem hiding this comment.
Nice breakdown of gameModes here!
Would use scream case here to better separate this from the other variables
e.g.
DICEROLL_MODE = 'diceRolling'
gameMode = DICEROLL_MODE
| var dicePush = function () { | ||
| var dicePush = [diceRoll(), diceRoll()]; | ||
|
|
||
| // Checking if player is 1 or 2, then pushing the dice numbers into the array | ||
| if (activePlayer == player1 && gameMode == diceRollMode) { | ||
| player1Dice = dicePush; | ||
| } else if (activePlayer == player2) { | ||
| player2Dice = dicePush; | ||
| } | ||
| return dicePush; |
There was a problem hiding this comment.
We usually don't assign arrays like this. It's better to do the push method
Reason being this idea of reference vs primitive types. - I'll run through this in class !
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
Please fill in one error and/or error message you received while working on this assignment.
script errors
What part of the assignment did you spend the most time on?
reordering the code to make it work. As whenever I want to add a new functionality to the game, I am unsure of where to place it.
Comfort Level (1-5):
2
Completeness Level (1-5):
4
What did you think of this deliverable?
Quite difficult compared to the scissors paper stone game.
Is there anything in this code that you feel pleased about?