#9-1 Hong Xi - Base #137
Open
#9-1 Hong Xi - Base #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return `Player 1 Wins. Press submit to restart new game.`; | ||
| } else { | ||
| console.log(`P1: ${p1Number}. P2: ${p2Number}.`); | ||
| gameMode = `rollingDice`; |
| console.log(`P1: ${p1Number}. P2: ${p2Number}.`); | ||
| gameMode = `rollingDice`; | ||
| return `Player 1 Wins. Press submit to restart new game.`; | ||
| } else { |
There was a problem hiding this comment.
Unnecessary 'else' after 'return'.
| if (gameMode == `checkWinner`) { | ||
| if (p1Number > p2Number) { | ||
| console.log(`P1: ${p1Number}. P2: ${p2Number}.`); | ||
| gameMode = `rollingDice`; |
| } | ||
| } | ||
| //Check Winners and loop game | ||
| if (gameMode == `checkWinner`) { |
| gameMode = `checkWinner`; | ||
| console.log(`Locked in Reverse ${revCombineP2}`); | ||
| console.log( | ||
| `Current mode: ${gameMode}. Current player: ${currentPlayer}` |
|
Code Climate has analyzed commit c58bd76 and detected 35 issues on this pull request. Here's the issue category breakdown:
Note: there are 20 critical issues. View more on Code Climate. |
eddiejpot
reviewed
Aug 3, 2021
Comment on lines
+9
to
+12
| //Player 1 roll | ||
| var p1Roll = [diceRoll(), diceRoll()]; | ||
| //Player 2 roll | ||
| var p2Roll = [diceRoll(), diceRoll()]; |
There was a problem hiding this comment.
Interesting choice of rolling the dice once the page loads!
I think for the purposes of this 2 player game it works! However always prepare for multiplayer so refactoring won't be such a headache . Heh!
Comment on lines
+6
to
+7
| //Starting game mode | ||
| gameMode = `rollingDice`; |
There was a problem hiding this comment.
Missing out var when declaring gameMode :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
3
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
Comfort Level (1-5):
4
Completeness Level (1-5):
4
What did you think of this deliverable?
Is there anything in this code that you feel pleased about?