Minor simplifications to typechecker #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
changed the title
ayazhafiz
force-pushed
the
ayaz/bugfix-ts
branch
from
82abed0 to
068b963
Compare
ayazhafiz
commented
Jan 2, 2025
There was a problem hiding this comment.
The changes here are correct. The old version was not. foo is unconditionally called in bar.
ayazhafiz
commented
Jan 2, 2025
There was a problem hiding this comment.
The changes here are correct. Because map is in a nested scope, it should not be generalized. Therefore the assignment of the lambdaset to f is valid.
ayazhafiz
force-pushed
the
ayaz/bugfix-ts
branch
from
068b963 to
9df9353
Compare
lukewilliamboswell
approved these changes
Jan 6, 2025
|
@ayazhafiz -- something may have gone wrong with your GPG signature? |
ayazhafiz
force-pushed
the
ayaz/bugfix-ts
branch
from
f5961cb to
8bddbe6
Compare
These are inferred vars, not rigids.
Remove branches on determining how let-bindings are introduced to the scope. This is maybe a little more inefficient, but I think it is a huge simplification. One additional change this required was changing how fx suffixes are checked. The current implementation would add additional constraints for patterns in let bindings conditionally. However, this is unnecessary. I believe it is sufficient to check the fx suffix by running the checks on all introduced symbols after the type is well known (i.e. the body is checked).
This is actually correct - the rigid approach is not. Lambda set variables should be inferred in-scope.
I don't think this assert is actually accurate.
ayazhafiz
force-pushed
the
ayaz/bugfix-ts
branch
from
8bddbe6 to
be99b82
Compare
|
Okay, resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing some simplifications ahead of a change to make named type variables where things are known to be a concrete type illegal.
See individual commits for details.