[Breaking Change] Simplify Refcounting #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of -max_size to -1 for regular refcounts, use 1 to max_size. 0 still means constant refcount. The highest bit is used to signify atomic refcounting required. This does not turn on any sort of atomic refcounting.
|
I must be missing a refcount change somewhere. As such, nqueens is not mutating in place. Thus a huge regression. |
|
Hmm... The regression must be linux or x86_64 specific. I am not seeing a regression on my m1 mac. Will do more testing later. |
|
Benchmarking fixed. Even improves perf by a tiny bit. |
ayazhafiz
previously approved these changes
Jan 2, 2025
| @@ -131,74 +127,7 @@ impl<'ctx> PointerToRefcount<'ctx> { | |||
| .allocation_alignment_bytes(layout_interner) | |||
| .max(env.target.ptr_width() as u32); | |||
|
|
|||
| let context = env.context; | |||
|
lukewilliamboswell
changed the title
lukewilliamboswell
previously approved these changes
Jan 9, 2025
|
@lukewilliamboswell should we merge this now? |
Signed-off-by: Brendan Hansknecht <[email protected]>
lukewilliamboswell
previously approved these changes
Jan 11, 2025
lukewilliamboswell
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of -max_size to -1 for regular refcounts, use 1 to max_size. 0 still means constant refcount.
The highest bit is used to signify atomic refcounting required. This does not turn on any sort of atomic refcounting.
WARNING: This is a breaking change for plaforms that interact with roc refcounts. The platforms will still initialize refcounts to
-max_sizewhich is now wrong.cc: @Anton-4 for thoughts on when to submit this.