Fixed issue #2457 #7361
Open
Fixed issue #2457 #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commas before function arguement types on lines will no longer give errors.
…to whitespace_func
| @@ -605,7 +605,10 @@ fn expression<'a>( | |||
| .parse(arena, state, min_indent)?; | |||
|
|
|||
| let (p2, rest, rest_state) = zero_or_more(skip_first( | |||
| backtrackable(byte(b',', EType::TFunctionArgument)), | |||
| backtrackable(skip_first( | |||
There was a problem hiding this comment.
Rather than doing skip_first, I think we need to be preserving this space in the tree. Otherwise we could accidentally lose a comment when formatting, for example.
Rather than separately tracking spaces before/after the comma, we should probably just merge them. There's a handy merge_spaces function for just that purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue of not allowing white space before commas that separated function arguments