Fixed Issue #6929 Escape unicode when inspecting a Str (#7411)

* Fixed Issue #6929 Escape unicode when inspecting Str added AUTHORS improved comment * update generated mono tests * fixed formatting * fixed merge conflicts
roc-lang · Jan 6, 2025 · 716374c · 716374c
1 parent 89ef225
commit 716374c
Show file tree

Hide file tree

Showing 19 changed files with 3,332 additions and 1,022 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -170,3 +170,4 @@ Isak Jones <[email protected]>
 Ch1n3du <[email protected]>
 Elias Mulhall <[email protected]>
 ABuffSeagull <[email protected]>
+Timon Krebs <[email protected]>
diff --git a/crates/compiler/builtins/roc/Inspect.roc b/crates/compiler/builtins/roc/Inspect.roc
@@ -258,7 +258,14 @@ dbgStr = \s ->
     custom \f0 ->
         f0
         |> dbgWrite "\""
-        |> dbgWrite s # TODO: Should we be escaping strings for dbg/logging?
+        |> \f1 ->
+            # escape invisible unicode characters as in fmt_str_body crates/compiler/fmt/src/expr.rs
+            escapeS =
+                Str.replaceEach s "\u(feff)" "\\u(feff)"
+                |> Str.replaceEach "\u(200b)" "\\u(200b)"
+                |> Str.replaceEach "\u(200c)" "\\u(200c)"
+                |> Str.replaceEach "\u(200d)" "\\u(200d)"
+            dbgWrite f1 escapeS
         |> dbgWrite "\""
 
 dbgOpaque : * -> Inspector DbgFormatter

diff --git a/crates/compiler/test_mono/generated/dbg_expr.txt b/crates/compiler/test_mono/generated/dbg_expr.txt