-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example platforms moved from Roc #224
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to wait on macos updates so I already did a partial review.
name = "host" | ||
version = "0.0.1" | ||
authors = ["The Roc Contributors"] | ||
license = "UPL-1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license should be changed to the license of this repo "CC0 1.0"
|
||
type Op_StderrWrite = roc_std::RocStr; | ||
type Op_StdoutWrite = roc_std::RocStr; | ||
type TODO_roc_function_69 = roc_std::RocStr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this TODO be changed before merging?
discriminant_Op::Done => f.write_str("Done"), | ||
discriminant_Op::StderrWrite => f | ||
.debug_tuple("StderrWrite") | ||
// TODO HAS CLOSURE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this TODO be handled before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this comment here so I don't forget, tests still need to be added to ci_scripts/all_tests.sh
|
||
Note: The JNI code depends on a dynamic lib, containing our native implementation, that now resides in our working directory.\ | ||
So in the following examples, we'll make sure that our working directory is in LD_LIBRARY_PATH.\ | ||
Generally speaking, you'd paobably add your dynamic library to a spot that's already on your path, for convenience sake.\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: probably
No description provided.