Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 146 #149

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Fix issue 146 #149

merged 4 commits into from
Jan 26, 2024

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Dec 29, 2023

Also simplifies http-get example.

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Dec 29, 2023

Segmentation faults are now happening in the examples command, echo, dir, env, file-read, form, hello-world...

❯ valgrind ./examples/hello-world 
==17767== Memcheck, a memory error detector
==17767== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==17767== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==17767== Command: ./examples/hello-world
==17767== 
Hello, World!
==17767== Can't extend stack to 0x485d138 during signal delivery for thread 1:
==17767==   no stack segment
==17767== 
==17767== Process terminating with default action of signal 11 (SIGSEGV)
==17767==  Access not within mapped region at address 0x485D138
==17767==    at 0xCCC040: ??? (in /home/username/gitrepos/basic-cli/examples/hello-world)
==17767==    by 0x48D1494: __run_exit_handlers (exit.c:113)
==17767==    by 0x48D160F: exit (exit.c:143)
==17767==    by 0x48B5D96: (below main) (libc_start_call_main.h:74)
==17767==  If you believe this happened as a result of a stack
==17767==  overflow in your program's main thread (unlikely but
==17767==  possible), you can try to increase the size of the
==17767==  main thread stack using the --main-stacksize= flag.
==17767==  The main thread stack size used in this run was 8388608.
==17767== 
==17767== HEAP SUMMARY:
==17767==     in use at exit: 0 bytes in 0 blocks
==17767==   total heap usage: 13 allocs, 13 frees, 3,213 bytes allocated
==17767== 
==17767== All heap blocks were freed -- no leaks are possible
==17767== 
==17767== For lists of detected and suppressed errors, rerun with: -s
==17767== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Segmentation fault (core dumped)

Building with --linker=legacy does not hit the issue.

@Anton-4

This comment was marked as outdated.

@Anton-4
Copy link
Collaborator Author

Anton-4 commented Dec 29, 2023

The segmentation fault is the same thing we encountered here and was already tracked in roc-lang/roc#5924.

@Anton-4 Anton-4 merged commit 0896641 into main Jan 26, 2024
3 checks passed
@Anton-4 Anton-4 deleted the fix_issue_146 branch January 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant