Fix the musl build #113
Merged
Fix the musl build #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing due to GC collecting functions we want to expose to the linker.
Anton-4
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Thanks @bhansconnect ❤️
If we were to add a new roc_fx function and we forgot to add it to this list would we get an error at build time?
Sadly no. The musl build will just silently not include the symbol....it is quite inconvenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was failing due to GC collecting functions we want to expose to the linker.
@Anton-4, this should fix the musl build while still enable a small binary with garbage collection. I guess in a static build, garbage collection is more aggressive because it assumes that functions can't be exposed to dynamic libraries. So we have to explicitly protect them.
When we eventually have effect interpreters, this should all go away and become a simple switch statement that uses the functions. This will stop them from getting GCed in general. (hmm, may still need it for roc_alloc and friends)