Skip to content

Commit

Permalink
Change http Timeout error to specify duration
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Rivas committed Feb 21, 2024
1 parent 2117413 commit e99ada0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions platform/Http.roc
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ handleStringResponse : Response -> Result Str Error
handleStringResponse = \response ->
when response is
BadRequest err -> Err (BadRequest err)
Timeout -> Err Timeout
Timeout ms -> Err (Timeout ms)
NetworkError -> Err NetworkError
BadStatus metadata _ -> Err (BadStatus metadata.statusCode)
GoodStatus _ bodyBytes ->
Expand All @@ -141,7 +141,7 @@ errorToString : Error -> Str
errorToString = \err ->
when err is
BadRequest e -> "Invalid Request: $(e)"
Timeout -> "Request timed out"
Timeout ms -> "Request timed out ($(Num.toStr ms)ms)"
NetworkError -> "Network error"
BadStatus code -> Str.concat "Request failed with status " (Num.toStr code)
BadBody details -> Str.concat "Request failed. Invalid body. " details
Expand Down
4 changes: 2 additions & 2 deletions platform/InternalHttp.roc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Body : [

Response : [
BadRequest Str,
Timeout,
Timeout U64,
NetworkError,
BadStatus Metadata (List U8),
GoodStatus Metadata (List U8),
Expand All @@ -41,7 +41,7 @@ Metadata : {

Error : [
BadRequest Str,
Timeout,
Timeout U64,
NetworkError,
BadStatus U16,
BadBody Str,
Expand Down

0 comments on commit e99ada0

Please sign in to comment.