feat: Enable per-alert Incident Severity #1701
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves on existing Incident.io implementation and allows to define per-alert incident severity in Incident.io (until now severity was determined by the alert severity, however not all alerts with the critical severity should have the same Incident.io severity).
The following configurational changes were made:
severity_alert_label_name
- label on the alert that will contain information about Incident.io severity. Default set torobusta_incidentio_severity
.severity_default
- sane default in case when label is not defineddashboard_url_annotation_name
- Incident.io has something called thesource_url
. Usually, that can be a link toward Grafana dashboard or anything else. In this case, it is a name of the alert annotation. Default set todashboard_url
.runbook_url_annotation_name
- same as with the Dashboard URL, stored as metadata information that can be extracted and parsed in Incident.io interface.Please note that severity names must be mapped in the Incident.io interface (whatever you pass - minor, major, critical) to the actual severity ID.
Risks
None
Performance impact
None
Security impact
None
How to QA