Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary code for config #64

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Remove unecessary code for config #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
829b245
Fix config and cli overrides
aantn Jun 23, 2024
3c489dc
remove extra code (logic is the same)
aantn Jun 24, 2024
e9c783f
Merge branch 'master' into fix-config-again
aantn Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions holmes/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,7 @@ def load_from_file(cls, config_file: Optional[str], **kwargs) -> "Config":
cli_options = {
k: v for k, v in kwargs.items() if v is not None and v != []
}
config_from_cli = cls(**cli_options)
if config_from_file is None:
return config_from_cli
return cls(**cli_options)

merged_config = config_from_file.dict()
Expand Down
Loading