Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dockerfile should download appropriate image for arm64 #263

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: dockerfile should download appropriate image for arm64 #263

merged 2 commits into from
Jan 30, 2025

Conversation

nherment
Copy link
Contributor

@nherment nherment commented Jan 30, 2025 •
edited
Loading

@nherment nherment marked this pull request as ready for review January 30, 2025 16:07
arikalon1
arikalon1 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit e04a5cd into master Jan 30, 2025
12 checks passed
@arikalon1 arikalon1 deleted the fix_docker_argocd_for_arm branch January 30, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

@moshemorad moshemorad Awaiting requested review from moshemorad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nherment @arikalon1