-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api authentication with tokens #97
Conversation
One question I have is: which endpoints should be accessible with an API token? All of them? As many as possible? Or is there a plan / strategy which endpoints? I.e. does a "change password" endpoint make sense to be available with a token? The underlying question is as well what permission does a token have / should a user when creating a token assign permissions to it? These are open design questions. |
I think the endpoints that should be accessible with the token should be endpoints that do anything with albatross (creating a unikernel, volumes, destroying them etc) and maybe requesting new tokens. For other activities, I think these should only be done via the dashboard |
We can add permissions to the tokens, I think that's a great idea, I can have another PR with that |
I completely agree, and would appreciate if we add - in this PR - a flag for authenticate I would not add To be more explicit, I'd guess the following endpoints are fine with a token:
Would you agree? Is there something missing? |
This sounds great. I definitely agree |
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
closes #38
This PR introduces many changes, including a refactoring of how we check for
csrf
tokens.In this PR:
The following endpoints can be accessed via the API
/api/volume/delete
/api/volume/create
/api/volume/download
/api/volume/upload
/api/unikernel/destroy
/api/unikernel/restart
/api/unikernel/create