Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap around host device and net name #74

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Swap around host device and net name #74

merged 4 commits into from
Oct 21, 2024

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Oct 19, 2024

The data was swapped according to the table header. That is, the network name internal to the unikernel was displayed under the title "Host Device" while the host bridge name was displayed under "Name".

@hannesm
Copy link
Contributor

hannesm commented Oct 19, 2024

Great observation. I wonder whether we should go a bit deeper here, and use a different wording.

So, we have the name as in the unikernel / solo5 manifest; and we have the name of the host system bridge (i.e. what is in the albatross policy).

Naming is hard, but maybe: "Unikernel network device | Host device"? I'd also put the unikernel network device first, but I guess this is a question of taste.

@hannesm
Copy link
Contributor

hannesm commented Oct 19, 2024

note: same for block devices, is swapped around, needs fixing

reynir and others added 2 commits October 19, 2024 15:34
The data was swapped according to the table header.
@hannesm
Copy link
Contributor

hannesm commented Oct 19, 2024

I went ahead and proposed the changes I had commented above. Please approve/reject

Automated ocamlformat GitHub action, developed by robur.coop and others added 2 commits October 19, 2024 13:40
Copy link
Collaborator

@PizieDust PizieDust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little suggestion. Please feel free to not approve them if it's better otherwise

unikernel_single.ml Show resolved Hide resolved
unikernel_single.ml Show resolved Hide resolved
@hannesm
Copy link
Contributor

hannesm commented Oct 20, 2024

The thing is we want to distinguish what the unikernel uses as name vs what the host system uses.... But I'm open for other wording suggestions.

@PizieDust
Copy link
Collaborator

The thing is we want to distinguish what the unikernel uses as name vs what the host system uses.... But I'm open for other wording suggestions.

ahh I see. Makes perfect sense now

@reynir reynir merged commit 1d39011 into main Oct 21, 2024
2 checks passed
@reynir reynir deleted the net-device branch October 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants