-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap around host device and net name #74
Conversation
Great observation. I wonder whether we should go a bit deeper here, and use a different wording. So, we have the name as in the unikernel / solo5 manifest; and we have the name of the host system bridge (i.e. what is in the albatross policy). Naming is hard, but maybe: " |
note: same for block devices, is swapped around, needs fixing |
The data was swapped according to the table header.
I went ahead and proposed the changes I had commented above. Please approve/reject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little suggestion. Please feel free to not approve them if it's better otherwise
The thing is we want to distinguish what the unikernel uses as name vs what the host system uses.... But I'm open for other wording suggestions. |
ahh I see. Makes perfect sense now |
The data was swapped according to the table header. That is, the network name internal to the unikernel was displayed under the title "Host Device" while the host bridge name was displayed under "Name".