One option for adding generic types #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
reviewed
Feb 6, 2024
|
If this sounds like a good path forward, I'll work on adding more generic types are time permits. |
|
This seems great. Any reason not to merge it in at this point? |
|
It's ready to merge. |
…o the profiled PID subsystem.
… Python naming convention. Added Generic annotations and a Protocol to profiledpidcommand.py.
…Aliases (FloatSupplier & FloatOrFloatSupplier). Updated UseOutputFucntion protocol based on testing.
virtuald
force-pushed
the
cwstryker/generic_types
branch
from
07af9dc to
604af69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there is a strong desire to implement better typing in the robotpy-commands-v2 library. There are potentially several ways to improve typing. The approach shown here uses TypeVar to create a generic type of ProfiledPIDController, named GenericProfiledPIDController. The generic type is defined in new typing.py file. The new generic type is then used in profiledpidsubsystem.py file as a type hint. See the file differences for more details.
Advantages: