Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevator Reset Zero Position Command #23

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

braelynandthefrogs
Copy link
Contributor

created and works with an error of about .04

@braelynandthefrogs braelynandthefrogs marked this pull request as ready for review February 7, 2025 04:31
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some random thoughts when looking through code in the morning. (Not related to the PR changes)

src/main/java/frc/robot/subsystems/ElevatorSubsystem.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/ElevatorSubsystem.java Outdated Show resolved Hide resolved
jamesdooley4
jamesdooley4 previously approved these changes Feb 8, 2025
src/main/java/frc/robot/Controls.java Outdated Show resolved Hide resolved
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@braelynandthefrogs braelynandthefrogs merged commit b48d441 into main Feb 11, 2025
2 checks passed
@KangarooKoala KangarooKoala deleted the elevator_subsystem_zeroing branch February 12, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants