Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for portaudioRecorder, portaudioPlayer device ID selection #3143

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Oct 15, 2024

Replaced parameter "id" in portaudioPlayer, portaudioRecorder with "a…udio_device_id" because "id" and "device_id" are keywords reserved by yarprobotinterface.
Additionally a new print now shows the name of the selected interface.

…udio_device_id" because "id" and "device_id" are keywords reserved by yarprobotinterface
@randaz81 randaz81 added Component: Devices PR Type: Bugfix This PR fixes some bug Type: Breaking/Behaviour Change Involves breaking user code or behaviour labels Oct 15, 2024
@randaz81 randaz81 added this to the YARP 3.10.0 milestone Oct 15, 2024
Copy link

update-docs bot commented Oct 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@traversaro
Copy link
Member

fyi @S-Dafarra @mebbaid @GiulioRomualdi @giotherobot @carloscp3009

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codacy-production bot commented Oct 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+35.99% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1a16d4b) 425225 79401 18.67%
Head commit (1d38488) 112299 (-312926) 61391 (-18010) 54.67% (+35.99%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3143) 15 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@randaz81 randaz81 merged commit f4ff1cb into master Oct 15, 2024
94 of 102 checks passed
@randaz81 randaz81 deleted the portaudio_id_fix branch October 15, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Devices PR Type: Bugfix This PR fixes some bug Type: Breaking/Behaviour Change Involves breaking user code or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants