Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add hints for configuring ANDROID_HOME #389

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Jan 26, 2025

It's just a hint for myself.

@utzcoz utzcoz requested a review from MGaetan89 January 26, 2025 13:19
@MGaetan89
Copy link
Member

Isn't this what this section is about? https://robolectric.org/building-robolectric/#installing-android-sdk-tools
Maybe we need to add more details to Installing Android SDK Tools if you think it's not clear enough?

@utzcoz utzcoz force-pushed the hints-for-ANDROID_HOME branch from f8a7ea1 to 852d1ee Compare January 27, 2025 08:27
@utzcoz
Copy link
Member Author

utzcoz commented Jan 27, 2025

@MGaetan89 NP. I moved the content to the end of Android sdk part.

Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved your changes in the Git/JDK section, instead of the Android one 😉

I've suggested an update to your content, feel free to pick what you feel works best

docs/building-robolectric.md Show resolved Hide resolved
@utzcoz utzcoz force-pushed the hints-for-ANDROID_HOME branch from 852d1ee to 7d8fa2a Compare January 28, 2025 09:25
@utzcoz utzcoz merged commit 5135919 into robolectric:master Jan 28, 2025
2 checks passed
@utzcoz utzcoz deleted the hints-for-ANDROID_HOME branch January 28, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants