Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized owlv2 model #889

Merged
merged 23 commits into from
Dec 20, 2024
Merged

Serialized owlv2 model #889

merged 23 commits into from
Dec 20, 2024

Conversation

probicheaux
Copy link
Collaborator

@probicheaux probicheaux commented Dec 18, 2024

Description

Adds ability to serialize/deserialize training data for owlv2 models

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

added tests

Any specific deployment considerations

new owlv2 endpoint needs to be deployed

Docs

  • Docs updated? What were the changes:

@probicheaux
Copy link
Collaborator Author

will need to be slightly modified when #886 makes it in to actually use the new endpoint/new method call with the workspace_id correctly

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024

CLA assistant check
All committers have signed the CLA.

@balthazur
Copy link
Contributor

@probicheaux should we put this up for review?

@probicheaux probicheaux marked this pull request as ready for review December 19, 2024 07:58
@probicheaux probicheaux requested a review from hansent as a code owner December 19, 2024 07:58
@balthazur balthazur mentioned this pull request Dec 19, 2024
8 tasks
Copy link
Contributor

@grzegorz-roboflow grzegorz-roboflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -71,6 +82,26 @@ def _check_size_limit(self):
self.popitem(last=False)


class Owlv2Singleton:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this can result in RAM exhaustion on long running processes that request multiple distinct models.

@grzegorz-roboflow grzegorz-roboflow merged commit f6473e4 into main Dec 20, 2024
85 checks passed
@grzegorz-roboflow grzegorz-roboflow deleted the serialized-owlv2-model branch December 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants