-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for handle timeouts #277
Conversation
cea6f25
to
c1de21d
Compare
c1de21d
to
d7930f6
Compare
@deoxxa what do you think about this? |
This actually looks perfectly reasonable. I can't really see anything wrong with it, and I'm sure it fits perfectly for this specific use case, but I'm also not totally convinced that it needs to be a top-level, core API function. I'm thinking it might be better to integrate What say ye, @stevenh? Any opinions? |
Yer context would be good, do we really think it would be that much more
work?
…On Sat, 21 Oct 2017 at 00:58, Conrad Pankoff ***@***.***> wrote:
This actually looks perfectly reasonable. I can't really see anything
wrong with it, and I'm sure it fits perfectly for this specific use case,
but I'm also not *totally* convinced that it needs to be a top-level,
core API function.
I'm thinking it might be better to integrate context.Context support
instead, since that's really emerging as *the* way to do deadlines and
timeouts. That is a larger job though and might not happen anytime soon -
it depends on someone putting in the work, and I know that I personally
don't have the time spare right now. If/when this happens, I wouldn't want
to have two (maybe incompatible or conflicting) ways to do timeouts.
What say ye, @stevenh <https://github.com/stevenh>? Any opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGXL5p1WooBbNhOk_zfpvMxBeNnL_38ks5suTOWgaJpZM4P4sVh>
.
|
I'm actually not sure - I'm just assuming there could be tricky stuff. It might be as easy as wiring up a handler between |
@deoxxa what signature would you like to see? In method Run, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better done with context.Context as then we get timeout and cancellation.
Closing due to age with no feedback |
I added a few new methods for avoiding workaround described in this section https://github.com/robertkrimen/otto#halting-problem
Fixes #278