-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to set timeout #278
Comments
I'm confused - you linked to the readme where it says exactly how to do what you want. I'm not sure what action you want someone to take. |
As user of library I want to run vm without knowing about |
I have nothing against the solution that you provide in Readme, but I'm sure it's a bad idea to have it in our codebase. It would be nice if it was a part of the library. So if there is a more elegant solution in the future, everyone who use it will have an updated version of solution. |
Is it something like the following which people are looking for: vm.RunContext(ctx, `code here`) |
@stevenh nowadays I think this is a preferred API, yes. |
It would be great to have a possibility to set a timeout to avoid workaround like this https://github.com/robertkrimen/otto#halting-problem
The text was updated successfully, but these errors were encountered: