Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of workers to scale up REST API #70

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Oct 22, 2024

This patch introduces the ability to increase the number of workers for the REST API via its configuration file.

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@r0x0d
Copy link
Member Author

r0x0d commented Oct 22, 2024

@tisnik probably this still needs some stuff to be finished. I was not sure where the documentation should go, so I found a config.puml in the docs folder. Let me know if there is more to be done here and where I should go to finish the task.

@r0x0d r0x0d force-pushed the increase-max-workers branch from f464be5 to 0b0102f Compare October 22, 2024 13:17
This patch introduces the ability to increase the number of workers for
the REST API via its configuration file.
@r0x0d r0x0d force-pushed the increase-max-workers branch from 0b0102f to 346bc00 Compare October 22, 2024 13:18
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok, I'd just suggest to remove the "optionality" of this attribute (if pydantic allow it)

ols/app/models/config.py Outdated Show resolved Hide resolved
@r0x0d r0x0d requested a review from tisnik October 23, 2024 13:12
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good!

@tisnik tisnik merged commit c301495 into road-core:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Ability to specify number of workers to allow REST API to be scaled up
3 participants